Fix Configuring Custom Dokka Plugin #3870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Register binding for `DokkaPluginParametersBuilder` - Remove @internal annotation on `jsonEncode()` for `DokkaPluginParametersBuilder` - Annotate the getter for `DokkaPluginParametersBuilder.objects` (the annotation only works for getters) - Add missing functions for adding files, directories, and maps, which were implied but not present for `DokkaPluginParametersBuilder` - remove overriden `DokkaPluginParametersBuilder.pluginFqn` property as it just caused issues - Add documentation for configuring custom plugins in dokka-migration.md Signed-off-by: solonovamax <[email protected]>
adam-enko
added
the
runner: Gradle plugin
|
Thank you for the approach, it helped me investigate the issue further. However, in addition to the problems you found, I found more issues, so we're going to remove it from DGP (see #3869 (comment)). Thank you again for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3869
DokkaPluginParametersBuilder@Internalannotation onjsonEncode()forDokkaPluginParametersBuilder(see [Bug] Cannot Configure Custom Dokka Plugin #3869)DokkaPluginParametersBuilder.objectsinstead of the field (the annotation only works for getters)DokkaPluginParametersBuilderDokkaPluginParametersBuilder.pluginFqnproperty as it just caused issues